Skip to content

[vscode-lm] Add missing model families and correct stale context limits - #19

Open
simurg79 wants to merge 2 commits into
mainfrom
feat/vscode-lm-model-table-integrity
Open

[vscode-lm] Add missing model families and correct stale context limits#19
simurg79 wants to merge 2 commits into
mainfrom
feat/vscode-lm-model-table-integrity

Conversation

@simurg79

@simurg79 simurg79 commented Sep 10, 2026

Copy link
Copy Markdown
Owner

What is the problem?

The built-in table of VS Code Language Model models had drifted from what the API actually offers. Several model families available through the VS Code LM provider were missing entirely, and some context-window figures for models that were listed had gone stale, so the extension reasoned about budgets that no longer matched reality.

How does this PR solve the problem?

It adds the missing model families and refreshes the stale context budgets in the shared model metadata, then updates the type, provider, and hook tests that assert against that table. The new figures come from a probe run against the live VS Code LM API rather than from vendor marketing pages, so the table reflects what the extension will actually be granted at runtime.

Where the probe could only establish a lower bound rather than an exact ceiling, the conservative lower bound was used instead of guessing upward. That is a deliberate trade-off: under-reporting a budget is safe, while over-reporting causes request failures. A small number of figures remain unverified and are documented as such rather than being silently presented as measured.

The extension version is also bumped from 3.53.5 to 3.53.6 so this model-table change ships under its own version. Only the extension manifest carries the version; every other consumer derives it, so no lockfile, package, or changelog updates were needed.

Companion documentation and probe evidence: https://github.com/simurg79/roo-vault/pull/648

How did you test the PR?

  • Scoped suites covering the changed areas: 98 tests passing.
  • packages/types full suite: 85 passing.
  • Provider suite: 1255 passing, 1 skipped.
  • Version bump: 4 manifest-integrity checks plus the packages/build suite, all passing with no failures.
  • Build: the packages/types package build plus type-checks across 3 packages, and ESLint: passing.
  • Commit hook lint: 10/10 packages passing; type-checks 10/10 passing on the version-bump commit.
  • Prettier check surfaced only CRLF line-ending noise with zero content difference; the one genuine cosmetic issue found was fixed.

The broader settings suite result is: 32 passing, 235 failing, 6 skipped. Only one representative Vertex failure group (4 passing, 1 failing) was re-run on the base commit and reproduced there; that specific failure is therefore pre-existing. The remaining failures were not established as pre-existing — no evidence supports generalising from that single sample. This PR does not claim a green full suite.

Deferred Items

Non-blocking review findings tracked separately; none change behaviour in this PR.

Agent notes
  • Scope: 5 files — shared model metadata/types, provider, hook tests, plus src/package.json version bump.
  • Base SHA: cd5596ccad7d143074deb04a7eea1b83deefc910; head 5bcaa0df37cf6baf1c4a49f8e9469b3b75c53e3d (was 832d92eae55070dbc39d771d984d3f309111b1b4).
  • Version bump commit 5bcaa0df37cf6baf1c4a49f8e9469b3b75c53e3d touches only the manifest; 3.53.5 → 3.53.6. Sole version consumer, others derive.
  • Target is the personal fork simurg79/Roo-Code by explicit user approval; upstream RooCodeInc/Roo-Code is NOT the target.
  • Caveats carried forward: Gemini 3.8 figure is a lower bound (955113). Opus value 680456 is the first-chunk measurement, not 680586 which produced an error. Vendor documentation, full-conversation behavior, and Grok image support remain unverified pending evidence.
  • Companion vault PR: https://github.com/simurg79/roo-vault/pull/648 — unchanged by this follow-up.
  • Pre-PR code review: PASS with notes. Gate 14 corrections applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant